Torchmodders

Modding => Modding Questions => Topic started by: Viz on March 23, 2017, 08:57:29 am


Title: crashing issue
Post by: Viz on March 23, 2017, 08:57:29 am
I encounter a bug with a class mods that I merged.

For some reason, Monk's attack causes the game to crash. At first I thought that it was related to a certain skill. But after further testing, the crash occurred right before delivering the killing blow to a monster.. regardless of skill.

I'd figure that its related to how the "fist wrap" upgrades damage on the first kill... so I look at the triggerables and the stat watcher.

Somehow the stat watcher has a numerical.. stuffs, idk why.

Code: [Select]
[STATWATCHER]
<STRING>STAT:EXPERIENCE LEVEL
<STRING>4082877041:MONK_UNARMED_LEVEL
<STRING>PRIMARY_TARGET_TYPE:SELF
<STRING>SECONDARY_TARGET_TYPE:SELF
<STRING>WATCH_TYPE:NOT EQUAL TO
[/STATWATCHER]
I tried changing the numbers to *random guessing* STAT_SECONDARY..it works for like..once, but then the crash occurs yet again.
Title: Re: crashing issue
Post by: Phanjam on March 23, 2017, 06:02:10 pm
Hi Viz! Have you compared that skill's code in your merged version, vs. the code in the original (un-merged) version.  Maybe there was a conflict during compiling of the merged version (I'm not sure, just guessing too :o )
Title: Re: crashing issue
Post by: Viz on March 24, 2017, 02:19:14 am
I did compare, they're pretty much same. ;(

so its either this class isn't meant to be merged or its something else.
Title: Re: crashing issue
Post by: Phanjam on March 24, 2017, 02:39:57 am
Just guessing again... how about "SECONDARY_STAT" instead of "STAT_SECONDARY"...
Title: Re: crashing issue
Post by: Viz on March 24, 2017, 04:40:13 am
Hmm. Apparently the correct string is SECOND_STAT. The crashing stopped, but I'm not sure if the Monk damage gets increased. Still need a further testing.
Title: Re: crashing issue
Post by: Phanjam on March 28, 2017, 04:41:35 am
Hey Viz! I saw your post on RGF...

Quote from: Viz
- Druid's Thorns skill icon is somehow missing.
- One of Voidseeker's passive is missing.[/COLOR]
- Theolentist - Game crashes when hovering the cursor to Nova skill icon.

The SKILLTREEOVERRIDE.LAYOUT has to be able to find the icon to show it in the tree. If it does not find it, the game WILL crash.

There are a few reasons in not finding the icon; the most common is missing image and .imageset files OR wrong image location stated in the .imageset file. So you might want to doublecheck those files and their contents first.

This post (http://torchmodders.com/forums/modding-questions/a-few-questions-about-altering-spell-scrolls/msg6360/#msg6360) about .imageset files might help you too...
Title: Re: crashing issue
Post by: Viz on March 29, 2017, 07:59:34 am
Oh hey, thanks for helping.

I've looked at those, but the .dds file do exist and .imageset position looks ok.

I read the comment section in the author's mod page and found out that apparently some players do encounter similar crashing issue related to Nova.




Title: Re: crashing issue
Post by: Viz on April 01, 2017, 04:13:53 am
Hmm, I tried to point it to the grey out version but it still crashes. Do I need to edit something in the skilltreeoverride.layout?
Title: Re: crashing issue
Post by: doudley on April 01, 2017, 04:36:46 am
Maybe I can help you out but I need some guiding because I'm not familiarized with most mods other than my own :P

What mod files are we talking about here? Can you give me some links on where I can download them and I could take a look at them myself?
Title: Re: crashing issue
Post by: Viz on April 01, 2017, 06:00:47 am
http://www.runicgamesfansite.com/mod_downloads/compilations-tl2/download-1516-variant-class-compilation-3-a.html

There you go. If anyone could upload it to Steam would be great, since I can't.   ::)
Title: Re: crashing issue
Post by: doudley on April 03, 2017, 06:39:31 am
The Unarmed Damage skills doesn't cause a game crash on me...

How can I recreate the crashing issue?

What should I do exactly?

Also, I'm not sure if it is any issue but when I unpacked the Variant.mod, GUTS reported missing TAGS (mostly on synergies' classes).
Title: Re: crashing issue
Post by: Viz on April 03, 2017, 07:14:42 am
Quote from: doudley on April 03, 2017, 06:39:31 am
The Unarmed Damage skills doesn't cause a game crash on me...

How can I recreate the crashing issue?

What should I do exactly?

Also, I'm not sure if it is any issue but when I unpacked the Variant.mod, GUTS reported missing TAGS (mostly on synergies' classes).
Oh yea, the unarmed damage was fixed some time ago.

The current issue is the Theolentist class. The game crashes when trying to hover to the Nova skill icon.

Regarding the missing tags, yeah I know. But I have no idea how to fix those..  AFAIK the affected skills are :
Spoiler (hover to show)

There are other missing tags as well, like most of the classes are missing their starting shoulder wardrobe and some skill particles went missing. But those aren't really game-breaking and can be figured out easily.
Title: Re: crashing issue
Post by: doudley on April 03, 2017, 08:55:31 am
Quote from: Viz on April 03, 2017, 07:14:42 am
The current issue is the Theolentist class. The game crashes when trying to hover to the Nova skill icon.
The IZAU_NOVA_ASTEROID skill is broken, check original data if the condition is the same. If it is broken, try contacting the author to fix it.

Quote from: Viz on April 03, 2017, 07:14:42 am
Regarding the missing tags, yeah I know. But I have no idea how to fix those..  AFAIK the affected skills are :
Spoiler (hover to show)

There are other missing tags as well, like most of the classes are missing their starting shoulder wardrobe and some skill particles went missing. But those aren't really game-breaking and can be figured out easily.
These TAGS could be exclusive from synergies and other mods where you claimed them, try getting the TAGS.DAT from synergies first and copy it to your mod pack. If the missing tags error has lessen then the TAGS.DAT is the cause.
Title: Re: crashing issue
Post by: Viz on April 03, 2017, 10:40:38 am
 ???

Idk why but everytime GUTS compiled the mod it **** up the asteroid.dat. Replaced it with the original .dat which pretty much untouched, still persist.

Also there's no tags.dat in those class mods so I guess I need to ask the mod authors, somehow.
Title: Re: crashing issue
Post by: doudley on April 03, 2017, 11:10:13 am
I'll check the Theolentist class mod alone. If there's no added TAGS in synergies then the missing tags could be caused by the merging of the mods and based on the files I've seen so far, they are messy (Probably you have nothing to do with that, you just compiled them).
Title: Re: crashing issue
Post by: TwinkleToes on April 03, 2017, 05:49:36 pm
the files are very likely messy lol

me and oedipustex were making the theolentist class before GUTS even came out
he was the designer and i did the art for the icons and class portrait.
Title: Re: crashing issue
Post by: Phanjam on April 04, 2017, 04:30:09 am
hey @doudley and @Viz , see also this discussion about tags.dat errors (http://torchmodders.com/forums/tl2-item-patch-public-board/information/msg3590/#msg3590). I don't know if it's solve-able actually :(
Title: Re: crashing issue
Post by: doudley on April 04, 2017, 10:00:10 pm
Quote from: Viz on April 03, 2017, 10:40:38 am
Idk why but everytime GUTS compiled the mod it screws up the asteroid.dat. Replaced it with the original .dat which pretty much untouched, still persist.
I've checked the Theolentist class mod alone, the IZAU_NOVA_ASTEROID skill is not broken there. Perhaps it gets broken due to the compile as you said. Try this, copy the mod files into your MEDIA folder again, then delete all .bindat and .binlayout files first before compiling it/building it (delete the editormod.dat too while your at it). Let me know if it works.

Quote from: TwinkleToes on April 03, 2017, 05:49:36 pm
the files are very likely messy lol
To be fair, I can easily detect Theolentist files because of prefix IZAU and ZOTT, I could say they are organized enough. Also, the skill icons and specially the character icons looks great! Are they hand-drawn traditionally or purely digital?

Quote from: Phanjam on April 04, 2017, 04:30:09 am
hey @doudley and @Viz , see also this discussion about tags.dat errors (http://torchmodders.com/forums/tl2-item-patch-public-board/information/msg3590/#msg3590). I don't know if it's solve-able actually :(
Thank you for the link @Phanjam! :)

Although, the explanation there is unclear to me and what's @Viz TAG issue with his mod pack seems different. I have my own personal mod pack and I know you have too, missing tag error in GUTS did not occur to me before, so its not definite that the issue could happen to anyone.

I read the link again, due to its complicated condition, I will not further investigate this matter. I'll just trust what Chthon said that "unknown tag doesn't do anything anyway".

I just think that it's a good advice to make it a habit, to clear all .bin[dat/layout] files before (re)compiling mods, especially on merged mods/mod packs.
Title: Re: crashing issue
Post by: TwinkleToes on April 05, 2017, 12:46:42 am
thanks :D
digitally hand drawn lol
Title: Re: crashing issue
Post by: Phanjam on April 05, 2017, 06:29:34 am
Quote from: doudley on April 04, 2017, 10:00:10 pm
I just think that it's a good advice to make it a habit, to clear all .bin[dat/layout] files before (re)compiling mods, especially on merged mods/mod packs.
Agree 100%
Title: Re: crashing issue
Post by: doudley on April 06, 2017, 02:00:57 am
Quote from: TwinkleToes on April 05, 2017, 12:46:42 am
thanks :D
digitally hand drawn lol
Thank you too...and you're awesome! :D

Thank you Phanjam too for agreeing!...although @Viz has not yet responded, if this mod has been furnished then maybe I'll be able to upload it on steam for him if he desires it.
Title: Re: crashing issue
Post by: Viz on April 06, 2017, 08:53:34 am
Hmm, the crash still persist. I did deleted every .bin/binlaout files and recompile the mod once again.

Anyway, I did an alternate solution to bypass the crash. I had to delete the asteroid.dat.
Since Nova was suppose to execute the asteroid and comet part, I figure I make the comet part execute twice to compensate the missing asteroid.

I hope you don't mind it, @TwinkleToes?

If nothing goes wrong I'll upload the new version (v4) some time in today. You can upload it on Steam, @doudley, I very much appreciate it.
Title: Re: crashing issue
Post by: Viz on April 06, 2017, 09:24:07 am
Oh wow.

It seems that the reason why Nova was crashing the game is due to the fact that there's conflicting GUIDs somewhere. So I reassigned it (asteroid.dat) to a new GUIDs and it seems working. 

No longer it would crash.

:D
Title: Re: crashing issue
Post by: doudley on April 06, 2017, 09:45:47 am
Nice one @Viz!

So, we can conclude that a mod with conflicting GUID when decompiled, can make a DAT's contents broken. I think it's also a good indication to know that you have a GUID conflict on your mod, this is great! I learned something new, although its too bad I wasn't able to help you much.

Yeah I'll wait for your update in RGF and I'll upload it on steam for you. ;)
Title: Re: crashing issue
Post by: doudley on April 07, 2017, 03:44:33 am
Please create a topic in the Mod Showcase category

Name it: Variant (Class Compilation)

The address link should look like this:
http://torchmodders.com/forums/mod-showcase/variant-(class-compilation)/

This is linked as your website in your mod pack that I will publish at Steam Workshop

This is also linked on your mod description at the mod's subscription page, if ever you won't entertain inquiries there. In here you will.

Your download site is linked to RGF

For further details about your mod's description, please let me know so that I can update it on Steam.
Title: Re: crashing issue
Post by: Viz on April 07, 2017, 04:50:16 am
Quote from: doudley on April 07, 2017, 03:44:33 am
Please create a topic in the Mod Showcase category

Name it: Variant (Class Compilation)

The address link should look like this:
http://torchmodders.com/forums/mod-showcase/variant-(class-compilation)/

This is linked as your website in your mod pack that I will publish at Steam Workshop

This is also linked on your mod description at the mod's subscription page, if ever you won't entertain inquiries there. In here you will.

Your download site is linked to RGF

For further details about your mod's description, please let me know so that I can update it on Steam.
Alright, done. It should be enough.  :)
Title: Re: crashing issue
Post by: doudley on April 07, 2017, 06:08:43 am
Quote from: Viz on April 07, 2017, 04:50:16 am
Alright, done. It should be enough.  :)
http://steamcommunity.com/sharedfiles/filedetails/?id=900049612

I'm done too. :)
Title: Re: crashing issue
Post by: Viz on April 07, 2017, 06:28:52 am
Quote from: doudley on April 07, 2017, 06:08:43 am
Quote from: Viz on April 07, 2017, 04:50:16 am
Alright, done. It should be enough.  :)
http://steamcommunity.com/sharedfiles/filedetails/?id=900049612

I'm done too. :)
Thanks! If possible could you add the "classes" tag to the mod?
Title: Re: crashing issue
Post by: Phanjam on April 07, 2017, 06:31:49 am
Congratulations guys! Nice work ;)
Title: Re: crashing issue
Post by: doudley on April 07, 2017, 06:32:39 am
Actually, this is what we have inside your mod:
STEAM_TAGS:Armor,Audio,Characters,Classes,Gameplay,Models,Monsters,Pets,Recipes,Skills,Textures,UI,Weapons

I'm not sure why steam won't show it like that...

EDIT:

I'll try to re-upload it next time.

Quote from: Phanjam on April 07, 2017, 06:31:49 am
Congratulations guys! Nice work ;)
Thanks! :)

EDIT2:

Probably there's a limit reached, I'll lessen the tags next time. The tags won't matter for now, your mod will be in the Popular category for a few weeks anyway.